tests: Add interoperability tests for BOLT12 (Offers) with CLN#905
Open
alexgrad42 wants to merge 1 commit into
Open
Conversation
|
I've assigned @tnull as a reviewer! |
alexgrad42
force-pushed
the
feature/add_bolt12_scenario_coverage_to_interop_tests
branch
2 times, most recently
from
bf29202 to
bd238f7
Compare
tnull
reviewed
May 18, 2026
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Thanks for looking into this! Some comments.
alexgrad42
force-pushed
the
feature/add_bolt12_scenario_coverage_to_interop_tests
branch
3 times, most recently
from
a41fc0a to
bb198e7
Compare
Activates scenarios for BOLT12 offer payments between ldk-node and Core Lightning (CLN) inside integration tests Fix lightningdevkit#856
alexgrad42
force-pushed
the
feature/add_bolt12_scenario_coverage_to_interop_tests
branch
from
bb198e7 to
a6eddd4
Compare
tnull
reviewed
May 21, 2026
| async fn create_offer( | ||
| &self, amount_msat: u64, description: &str, | ||
| ) -> Result<String, TestFailure> { | ||
| Err(self.make_error("create_offer is not supported on Eclair".to_string())) |
Collaborator
There was a problem hiding this comment.
Hmm, I think this shouldn't be true anymore, no? Can you double-check that the latest docker image really doesn't support BOLT12? If it does we should def. un-ignore the Eclair BOLT12 test coverage in this PR.
tnull
reviewed
May 21, 2026
| async fn test_splice_in() { | ||
| run_interop_scenario(setup_clients(), splice_in_scenario).await; | ||
| async fn test_splice_in_bolt11() { | ||
| run_interop_scenario(setup_clients(), splice_in_bolt12_scenario).await; |
Collaborator
There was a problem hiding this comment.
Codex:
- [P3] Run the BOLT11 splice scenario — /home/tnull/workspace/ldk-node/tests/integration_tests_eclair.rs:87-87
When the ignored Eclair splice test is run, this *_bolt11 test executes the BOLT12 splice scenario instead, so it never covers the BOLT11 path and will fail for Eclair's current lack of BOLT12 support. This should call splice_in_bolt11_scenario.
| }); | ||
|
|
||
| let response: serde_json::Value = self | ||
| .rpc(move |c| c.call("offer", params)) |
Collaborator
There was a problem hiding this comment.
Codex:
- [P1] Borrow CLN RPC parameter values — /home/tnull/workspace/ldk-node/tests/common/cln.rs:205-205
Under the CLN integration build, LightningRPC::call takes the params by reference, matching the existing &json!(...)/¶ms call sites. Passing the new serde_json::Value by value here, and again for fetchinvoice, will fail to type-check under --cfg cln_test; pass a borrow instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Activates scenarios for BOLT12 offer payments between ldk-node and Core Lightning (CLN) inside integration tests
Fix #856